prepare for switching to Linsolve Interface #2585
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
force-pushed
the
os/prepare-for-linsolve-refactor
branch
from
9df099e to
af961e5
Compare
|
Time to start up on this again. |
|
I think this now works (with deprecations for the old precs interface). WP diagram incoming. |
oscardssmith
force-pushed
the
os/prepare-for-linsolve-refactor
branch
from
1aff3ae to
f0eadac
Compare
|
Looks like CI isn't using the deved versions here. Any idea why? |
|
Just on LTS |
|
oh, is LTS CI not deving the sources properly? |
|
yeah LTS ignores sources. That's a Pkg thing. |
| sol = @test_nowarn solve(prob, | ||
| sol = solve(prob, | ||
| TRBDF2(autodiff = AutoFiniteDiff(), linsolve = KrylovJL_GMRES(), | ||
| precs = precsl, smooth_est = false, concrete_jac = true)); |
There was a problem hiding this comment.
instead update the preconditioners being tested? Also the docs tutorial on this will need an update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of a redesign of #2318 to make it actually mergable. Specifically, this PR updates OrdinaryDiffEqRosenbrock and OrdinaryDiffEqNonlinearSolve to pass the
du,u,p, andtvia the NonlinearProblem rather than todolinsolve. In a followup PR, I will then remove these fields fromdolinsolve, but I think doing things this way will make it so we can make the OrdinaryDiffEqDifferentiation change require a new enough version of the solver libraries to not get unexpected inputs.