Skip to content

Conversation

@jClugstor
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@jClugstor
Copy link
Member Author

will need SciML/SciMLBase.jl#1159 to fully work

@termi-official
Copy link
Contributor

Since you are already working on the logging system, is there any chance that we can have additional logging messages for the time integration loop at trace level to debug issues in the timestepping itself? Or is that too costly?

@ChrisRackauckas
Copy link
Member

We are splitting that to a different step. First let's get the infrastructure together, then add new messages.

Or is that too costly?

Never! If it's super costly, just put it in the All preset only. Semi? Detailed. Since there's individual switching and tons of levels, the goal is to just add tons and tons of default prints and if they are costly just don't have them on by default, but if you switch to All then you just get a lot of information.

@jClugstor jClugstor marked this pull request as ready for review October 24, 2025 16:45
@jClugstor
Copy link
Member Author

At this point anything that was behind a verbose is now under a @SciMLMessage and is controlled by an ODEVerbosity.

Currently, the linear_verbosity and nonlinear_verbosity fields are not used because those get set in alg_cache or build_nlsolver which do not have access to the integrator or the DEOptions where the verbosity object is. So setting those in ODEVerbosity will not do anything.

For the Linear solves and Nonlinear solves I set verbose to Minimal() to prevent unnecessary printing from those during an ODE solve.

@ChrisRackauckas
Copy link
Member

is this ready to review?

@jClugstor
Copy link
Member Author

Yep, ready to be looked at.

@ChrisRackauckas
Copy link
Member

Lots of test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants