Fix CI: skip AMG preconditioner tests on Julia 1.10, fix Runic formatting#3045
Merged
ChrisRackauckas merged 2 commits intoSciML:masterfrom Feb 12, 2026
Conversation
…matting AlgebraicMultigrid.ruge_stuben triggers a LAPACK gesdd! bug on Julia 1.10 when computing pseudoinverse during AMG coarsening. Gate AMG preconditioner tests behind VERSION >= v"1.11-" to avoid the upstream LAPACK error. Also fix Runic formatting: 1e-3 -> 1.0e-3 in psos_and_energy_conservation.jl. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove AlgebraicMultigrid preconditioner tests entirely from preconditioners.jl. AMG triggers a LAPACK gesdd! bug on Julia 1.10 when computing pseudoinverse during coarsening. The ILU preconditioner tests remain and cover the preconditioner interface adequately. Also fix Runic formatting: - 1e-3 -> 1.0e-3 in psos_and_energy_conservation.jl - Add missing return keywords in BS5, Vern6-9, RKV76IIa Bool->Val converters Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Updated approach: Removed AMG preconditioner tests entirely per review feedback, rather than gating them behind a version check. Also fixed additional Runic formatting issues discovered in CI:
These are the Bool-to-Val backwards compatibility converter functions added in PR #3044. |
Contributor
Author
|
CI Status Summary:
The two failures need a re-run to confirm they're just infra flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two CI failures on master:
test (ModelingToolkit, lts)failure:AlgebraicMultigrid.ruge_stubentriggers a LAPACKgesdd!"invalid argument Native Adams-Bashforth-Moulton methods #4" error on Julia 1.10 when computing pseudoinverse (Pinv) during AMG coarsening. This is an upstream bug in LAPACK/Julia 1.10, not in OrdinaryDiffEq. The fix gates AMG preconditioner tests behindVERSION >= v"1.11-"— the non-AMG preconditioner tests (ILU) still run on all Julia versions.format-checkfailure: Runic requires1.0e-3instead of1e-3intest/regression/psos_and_energy_conservation.jl.Test plan
runic --check .🤖 Generated with Claude Code