Merged
Conversation
- Remove `__precompile__()` call (no-op since Julia 1.8, modules precompile by default) - Replace removed `warn()` function with `@warn` macro in dict_build.jl (`warn` was removed from Base in Julia 1.0) - Fix `build_param_list` returning undefined `param_dict` instead of `param_list` - Fix typo "my be" -> "may be" in warning message - Remove commented-out dead code using deprecated `lufact()` API (Jacobian LU factorization code that used SymEngine.Basic) Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__precompile__()call (no-op since Julia 1.8, modules precompile by default)warn()function calls with@warnmacro indict_build.jl(warnwas removed from Base in Julia 1.0)build_param_listreturning undefined variableparam_dictinstead ofparam_listlufact()API (old Jacobian LU factorization code that used SymEngine.Basic)Details
While no deprecation warnings are currently emitted at runtime (tests pass with
--depwarn=error), the codebase contained usage of APIs that have been removed from Julia:warn()function (removed in Julia 1.0, replaced by@warnmacro): Used inbuild_indvar_dictandbuild_param_listindict_build.jl. These code paths would causeUndefVarErrorif reached.__precompile__(): Deprecated since Julia 1.8. All modules precompile by default now.build_param_listbug: The function returnedparam_dict(undefined) instead ofparam_list. This function is currently unused but was broken.Commented-out code with
lufact(): Dead code from the SymEngine era usinglufact()(renamed toluin Julia 1.0) andMatrix{SymEngine.Basic}.Upstream dependencies note
No upstream dependency changes needed. All current MTK v11 APIs used (
tosymbol,generate_rhs,generate_tgrad,generate_jacobian,generate_factorized_W,System) work without deprecation warnings.The
test_undefined_exportsAqua test remainsbroken = truedue to MTK v11 exportingVariableandfind_solvables!which are undefined — this is an upstream MTK issue.Test plan
julia --depwarn=error(direct invocation)Pkg.test()🤖 Generated with Claude Code