Skip to content

Conversation

@jClugstor
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

In the construction of FixedSizeDiffCache we create the Dual numbers with tag nothing. This changes it to use Nothing for the tag, which is consistent with zero for Dual numbers.

julia> zero(ForwardDiff.Dual)
Dual{Nothing}(0)

This is related to EnzymeAD/Enzyme.jl#2371.

@jClugstor
Copy link
Member Author

Well it looks like that messed with a lot more than I thought it would...

@ChrisRackauckas
Copy link
Member

It looks fine?

@jClugstor
Copy link
Member Author

Oh yeah, looks like the build kite failures are just CUDA failing to initialize, which shouldn't be related to this.

@jClugstor
Copy link
Member Author

@ChrisRackauckas test is in here now

@ChrisRackauckas ChrisRackauckas merged commit 1902d93 into SciML:master Apr 30, 2025
10 of 19 checks passed
@jClugstor jClugstor deleted the scimlsensitivity_bug_fix branch April 30, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants