Add resize! dispatch for DiffCache and FixedSizeDiffCache #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds resize! methods for DiffCache and FixedSizeDiffCache structs to fix resize! operations in downstream packages like Trixi.jl. The implementation resizes the internal arrays (du, dual_du, any_du) appropriately, with proper handling for vector vs non-vector arrays. - Added Base.resize! methods for both DiffCache and FixedSizeDiffCache - Only resizes vector arrays (throws error for non-vectors since resize! doesn't work on matrices) - Added ForwardDiff to weakdeps in Project.toml (was missing) - Added comprehensive tests for resize! functionality - Formatted code with JuliaFormatter using SciMLStyle 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ChrisRackauckas
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
resize!methods forDiffCacheandFixedSizeDiffCachestructs to fix resize! operations in downstream packages like Trixi.jl.Fixes the error seen in https://github.com/trixi-framework/Trixi.jl/actions/runs/16993514504/job/48178504581?pr=2522#step:7:2026
Changes
Base.resize!methods for bothDiffCacheandFixedSizeDiffCachedu,dual_du,any_du) appropriatelyresize!doesn't work on matrices)Test plan
resize!functionality intest/core_resizing.jl🤖 Generated with Claude Code