Add fill! overloads for cache types #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas-Claude
force-pushed
the
add-zero-function
branch
from
9fe4ff0 to
1c84df5
Compare
ChrisRackauckas-Claude
changed the title
ChrisRackauckas-Claude
force-pushed
the
add-zero-function
branch
from
1c84df5 to
0ec9824
Compare
This adds fill! overloads for DiffCache, FixedSizeDiffCache, LazyBufferCache, and GeneralLazyBufferCache that fill all allocated buffers with a given value. This is needed to ensure proper initialization of caches in split ODE methods to avoid convergence issues. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ChrisRackauckas-Claude
force-pushed
the
add-zero-function
branch
from
0ec9824 to
07a5510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fill!overloads for all cache types (DiffCache, FixedSizeDiffCache, LazyBufferCache, GeneralLazyBufferCache)Background
After the change in DiffEqBase.jl PR #1188 that prevents replacing LazyBufferCache when promoting functions, split ODE methods started failing convergence tests. The issue is that uninitialized cache buffers contain random values that accumulate into the solution, causing unpredictable errors that break convergence rate tests.
Solution
This PR adds
fill!overloads that can be called to fill caches with any value, including zero. This uses the standard Juliafill!interface which is more idiomatic than adding a customzero!function.Implementation
The
fill!methods:DiffCacheandFixedSizeDiffCache: Fill bothduanddual_duarrays with the value, and clearany_duLazyBufferCacheandGeneralLazyBufferCache: Iterate through all allocated buffers and fill them with the valueTest plan
🤖 Generated with Claude Code