Skip to content

Conversation

@github-actions
Copy link

This pull request changes the compat entry for the ModelingToolkit package from 9 to 9, 11.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ChrisRackauckas-Claude
Copy link

ModelingToolkit v11 Compatibility Fix Required

I've analyzed this PR and identified a breaking change that needs to be addressed for ModelingToolkit v11 compatibility.

Issue

ModelingToolkit v11.0.0 (released December 11, 2024) removed the get_defaults function as part of a redesign of the initialization system. The concept of "defaults" has been replaced with initial_conditions and bindings.

Required Changes

Two test files import get_defaults but never use it. These imports need to be removed:

test/Reactor_tests/Jacket_test.jl (line 4):

-import ModelingToolkit: get_unknowns, get_observed, get_defaults, get_eqs, scalarize
+import ModelingToolkit: get_unknowns, get_observed, get_eqs, scalarize

test/Sources_tests/source_tests.jl (line 3):

-import ModelingToolkit: get_unknowns, get_observed, get_defaults, get_eqs
+import ModelingToolkit: get_unknowns, get_observed, get_eqs

Notes

  • The imported get_defaults function is not actually called in any of the test files, so removing it is safe
  • These are the only changes needed for v11 compatibility based on my analysis of the codebase
  • The rest of the code uses ModelingToolkit APIs that remain compatible with v11

I attempted to push these fixes directly to the PR branch but don't have push permissions. These changes should allow CI to pass once applied.

cc @ChrisRackauckas

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants