Interface compatibility: Parameterize Reaction and MaterialSource types #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves interface compliance with SciML's array/number interface guidelines by making the
ReactionandMaterialSourcestructs parametric:Reaction{T<:Real}now allows arbitrary numeric types for stoichiometry (ν::Vector{T})MaterialSource{T<:Real, R<:Reaction}now allows arbitrary numeric types for molar weights (Mw::Vector{T})Interface Issues Found and Fixed
Issue 1: Hardcoded
Float64inReactionstructIssue 2: Hardcoded
Float64inMaterialSourcestructTesting Performed
ReactionandMaterialSourcecan now be created withBigFloatarrays without type conversionFloat32arrays work correctlyFloat64continues to work unchangedtest/interface_tests.jltests all numeric type variantsNotes on JLArray/GPU Compatibility
This package uses ModelingToolkit for symbolic equation building. GPU compatibility for the actual ODE solving would be handled at the solver level (DifferentialEquations.jl), not in this package. The scalar indexing used in the package occurs during symbolic equation construction, not during numeric computation.
Test plan
julia --project=. -e 'using Test; include("test/interface_tests.jl")'- all 21 tests passcc @ChrisRackauckas
🤖 Generated with Claude Code