Skip to content

CompatHelper: bump compat for ModelingToolkit to 10 for package downstream, (keep existing compat) #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CompatHelper: bump compat for ModelingToolkit to 10 for package downstream, (keep existing compat) #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
781e9bd
CompatHelper: bump compat for ModelingToolkit to 10 for package downs…
May 29, 2025
092f9c2
test: update tests to MTKv10
AayushSabharwal May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/downstream/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"

[compat]
ModelingToolkit = "8.33, 9"
ModelingToolkit = "10"
MonteCarloMeasurements = "1.1"
OrdinaryDiffEq = "6.31"
StaticArrays = "1"
Expand Down
12 changes: 5 additions & 7 deletions test/downstream/symbol_indexing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ include("../testutils.jl")
@variables x(t)
@parameters τ
@variables RHS(t)
@mtkbuild fol_separate = ODESystem([RHS ~ (1 - x) / τ,
D(x) ~ RHS], t)
@mtkcompile fol_separate = System([RHS ~ (1 - x) / τ, D(x) ~ RHS], t)

prob = ODEProblem(fol_separate, [x => 0.0], (0.0, 10.0), [τ => 3.0])
prob = ODEProblem(fol_separate, [x => 0.0, τ => 3.0], (0.0, 10.0))
sol = solve(prob, Tsit5())

sol_new = DiffEqArray(sol.u[1:10],
Expand Down Expand Up @@ -50,11 +49,10 @@ test_tables_interface(sol_new, [:timestamp, Symbol("x(t)")], hcat(sol_new[t], so
# Two components
@variables y(t)
@parameters α β γ δ
@mtkbuild lv = ODESystem([D(x) ~ α * x - β * x * y,
@mtkcompile lv = System([D(x) ~ α * x - β * x * y,
D(y) ~ δ * x * y - γ * x * y], t)

prob = ODEProblem(lv, [x => 1.0, y => 1.0], (0.0, 10.0),
[α => 1.5, β => 1.0, γ => 3.0, δ => 1.0])
prob = ODEProblem(lv, [x => 1.0, y => 1.0, α => 1.5, β => 1.0, γ => 3.0, δ => 1.0], (0.0, 10.0))
sol = solve(prob, Tsit5())

ts = 0:0.5:10
Expand All @@ -69,7 +67,7 @@ sts = @variables x(t)[1:3]=[1, 2, 3.0] y(t)=1.0
ps = @parameters p[1:3] = [1, 2, 3]
eqs = [collect(D.(x) .~ x)
D(y) ~ norm(collect(x)) * y - x[1]]
@mtkbuild sys = ODESystem(eqs, t, sts, ps)
@mtkcompile sys = ODESystem(eqs, t, sts, ps)
prob = ODEProblem(sys, [], (0, 1.0))
sol = solve(prob, Tsit5())
@test sol[x .+ [y, 2y, 3y]] ≈ vcat.(getindex.((sol,), [x[1] + y, x[2] + 2y, x[3] + 3y])...)
Expand Down
Loading