Skip to content

Remove Julia v1.9 get_extension compatibility code #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 6 commits into from
Jul 29, 2025
Merged

Remove Julia v1.9 get_extension compatibility code #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
564f274
Remove Julia v1.9 get_extension compatibility code
ChrisRackauckas Jul 27, 2025
51e15db
Update PlotsExt.jl
ChrisRackauckas Jul 27, 2025
f627147
Update src/RootedTrees.jl
ChrisRackauckas Jul 27, 2025
62c2059
Update Project.toml
ChrisRackauckas Jul 27, 2025
1ca9941
Merge branch 'main' into remove-get-extension-compat
ChrisRackauckas Jul 27, 2025
cad57ad
Update src/RootedTrees.jl
ChrisRackauckas Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Latexify = "23fbe1c1-3f47-55db-b15f-69d7ec21a316"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Preferences = "21216c6a-2e73-6563-6e65-726566657250"
RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"
Requires = "ae029012-a4dd-5104-9daa-d747884805df"

[weakdeps]
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
Expand All @@ -24,8 +23,7 @@ LinearAlgebra = "1"
Plots = "1"
Preferences = "1.3"
RecipesBase = "1"
Requires = "1"
julia = "1.6"
julia = "1.10"

[extras]
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
6 changes: 1 addition & 5 deletions ext/PlotsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
module PlotsExt

if isdefined(Base, :get_extension)
using Plots: Plots
else
import ..Plots: Plots
end
using Plots: Plots

using RootedTrees: RootedTrees

Expand Down
11 changes: 0 additions & 11 deletions src/RootedTrees.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ using Latexify: Latexify
using Preferences: @set_preferences!, @load_preference
using RecipesBase: RecipesBase

if !isdefined(Base, :get_extension)
using Requires: @require
end

export RootedTree, rootedtree, rootedtree!, RootedTreeIterator,
ColoredRootedTree, BicoloredRootedTree, BicoloredRootedTreeIterator

Expand Down Expand Up @@ -1604,15 +1600,8 @@ function __init__()
Threads.resize_nthreads!(PARTITION_ITERATOR_BUFFER_EDGE_SET_TMP,
Vector{Bool}(undef, BUFFER_LENGTH))

@static if !isdefined(Base, :get_extension)
@require Plots="91a5bcdd-55d7-5caf-9e0b-520d859cae80" begin
include("../ext/PlotsExt.jl")
end
end

return nothing
end

# explicit precompilation
include("precompile.jl")

Expand Down
Loading