Skip to content

Conversation

@Zf98ai
Copy link
Contributor

@Zf98ai Zf98ai commented Apr 29, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • [X ] All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

fix format.

@Zf98ai
Copy link
Contributor Author

Zf98ai commented May 5, 2025

@ChrisRackauckas Thank you for reviewing my pull requests!

I just wanted to clarify the situation:
After I submitted the first PR (#1008), I later noticed it didn’t pass CI, so I assumed it hadn’t been merged. I assumed the formatting issue might be the reason, so I submitted a second PR (#1009) with revised formatting. At the time, I didn’t realize that the first PR had already been merged and closed.

Now I see that the second PR was closed and then reopened, so I wanted to check whether there’s anything further I need to do, or if the changes from the first PR are already sufficient.

Apologies for the confusion, and thank you again for your help!

@ChrisRackauckas
Copy link
Member

It's failing because it's currently running with JuliaFormatter v1. I think we need to update the CI but I had issues when I tried. @thazhemadam ?

@ChrisRackauckas
Copy link
Member

This got fixed in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants