Skip to content

test: make ensemble multi prob test independent of variable order #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

test: make ensemble multi prob test independent of variable order #1048

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b59fd2
test: make ensemble multi prob test independent of variable order
AayushSabharwal Jun 5, 2025
6260254
test: make solution interface tests independent of variable order
AayushSabharwal Jun 5, 2025
28e99e0
Update test/downstream/solution_interface.jl
ChrisRackauckas Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/downstream/ensemble_multi_prob.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using ModelingToolkit, OrdinaryDiffEq, Test
using SymbolicIndexingInterface
using ModelingToolkit: t_nounits as t, D_nounits as D
@variables x(t), y(t)

Expand All @@ -16,10 +17,12 @@ prob3 = ODEProblem(sys3, [3.0, 3.0], (0.0, 1.0))
# test that when passing a vector of problems, trajectories and the prob_func are chosen appropriately
ensemble_prob = EnsembleProblem([prob1, prob2, prob3])
sol = solve(ensemble_prob, Tsit5(), EnsembleThreads())
xidx = variable_index(sys1, x)
yidx = variable_index(sys1, y)
for i in 1:3
@test sol[1, :, i] == sol.u[i][x]
@test sol[2, :, i] == sol.u[i][y]
@test sol[xidx, :, i] == sol.u[i][x]
@test sol[yidx, :, i] == sol.u[i][y]
end
# Ensemble is a recursive array
@test only.(sol(0.0, idxs = [x])) == sol[1, 1, :]
@test only.(sol(1.0, idxs = [x])) ≈ [sol[i][1, end] for i in 1:3]
@test only.(sol(0.0, idxs = [x])) == sol[xidx, 1, :]
@test only.(sol(1.0, idxs = [x])) ≈ [sol[i][xidx, end] for i in 1:3]
9 changes: 5 additions & 4 deletions test/downstream/solution_interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ prob = ODEProblem(sys, [u0; p], tspan)
sol = solve(prob, Rodas4())

@test_throws ArgumentError sol[x]
@test in(sol[lorenz1.x], [getindex.(sol.u, 1) for i in 1:length(unknowns(sol.prob.f.sys))])
@test in(sol[lorenz1.x], [getindex.(sol.u, i) for i in 1:length(unknowns(sol.prob.f.sys))])
@test_throws KeyError sol[:x]

### Non-symbolic indexing tests
Expand Down Expand Up @@ -331,13 +331,14 @@ end
@test _idxs == [1]
@test _ss isa SciMLBase.SavedSubsystem
_idxs, _ss = SciMLBase.get_save_idxs_and_saved_subsystem(prob, x)
@test _idxs == 1
xidx = variable_index(prob, x)
@test _idxs == xdx
@test _ss isa SciMLBase.SavedSubsystem
_idxs, _ss = SciMLBase.get_save_idxs_and_saved_subsystem(prob, [x])
@test _idxs == [1]
@test _idxs == [xidx]
@test _ss isa SciMLBase.SavedSubsystem
_idxs, _ss = SciMLBase.get_save_idxs_and_saved_subsystem(prob, [x, q])
@test _idxs == [1]
@test _idxs == [xidx]
@test _ss isa SciMLBase.SavedSubsystem
_idxs, _ss = SciMLBase.get_save_idxs_and_saved_subsystem(prob, [q])
@test _idxs == Int[]
Expand Down
Loading