Add validation for constrained optimization problems missing bounds #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a constrained optimization problem has constraints defined but is missing lcons or ucons bounds, provide a helpful error message instead of allowing it to fail with cryptic errors downstream. This addresses SciML/Optimization.jl#959 by adding the validation at the SciMLBase level so all optimization solvers benefit from it. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds validation to ensure that constrained optimization problems have both
lconsanduconsbounds defined when constraints are present. This addresses issue SciML/Optimization.jl#959.Problem
When users forget to provide
lconsanduconsfor a constrained optimization problem, they get unhelpful errors like:Solution
Added a check in the
_check_opt_algfunction that validates:allowsconstraints(alg))\!isnothing(prob.f.cons))lconsoruconsis missingArgumentErrorwith an exampleExample Error Message
Benefits
This validation at the SciMLBase level ensures all optimization solvers benefit from the improved error message, providing a uniform experience across the ecosystem.
Related
no method matching keys(::Nothing)when I forget to passlconsanduconsto a constrained problem Optimization.jl#959🤖 Generated with Claude Code