Skip to content

nothing is a perfectly valid nonlinear solver algorithm #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

nothing is a perfectly valid nonlinear solver algorithm #1081

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a9ebe1
`nothing` is a perfectly valid nonlinear solver algorithm
ChrisRackauckas Jul 28, 2025
9ca596f
Update initialization.jl
ChrisRackauckas Jul 29, 2025
b4db702
Update test/downstream/initialization.jl
ChrisRackauckas Jul 29, 2025
d8efe11
Update tests for nothing as valid nlsolve_alg
claude Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/initialization.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,6 @@ function get_initial_values(prob, valp, f, alg::OverrideInit,
success = true
else
nlsolve_alg = something(nlsolve_alg, alg.nlsolve, Some(nothing))
if nlsolve_alg === nothing && state_values(initprob) !== nothing
throw(OverrideInitMissingAlgorithm())
end
if alg.abstol !== nothing
_abstol = alg.abstol
elseif abstol !== nothing
Expand Down
3 changes: 1 addition & 2 deletions test/downstream/initialization.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,7 @@ end
integ = init(prob; initializealg = NoInit())

@testset "Errors without `nlsolve_alg`" begin
@test_throws SciMLBase.OverrideInitMissingAlgorithm SciMLBase.get_initial_values(
prob, integ, fn, SciMLBase.OverrideInit(), Val(false))
SciMLBase.get_initial_values(prob, integ, fn, SciMLBase.OverrideInit(), Val(false))
end

abstol = 1e-10
Expand Down
Loading