Move Moshi to extension for 17.5% load time reduction #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves RecipesBase and RuntimeGeneratedFunctions from direct dependencies to weak dependencies with corresponding extensions, reducing the load time footprint of SciMLBase. Changes: - Moved RecipesBase from deps to weakdeps in Project.toml - Moved RuntimeGeneratedFunctions from deps to weakdeps in Project.toml - Created SciMLBaseRecipesBaseExt.jl extension containing all @recipe definitions - Created SciMLBaseRuntimeGeneratedFunctionsExt.jl extension with numargs method - Removed RecipesBase import from main SciMLBase.jl module - Removed RuntimeGeneratedFunctions import from main SciMLBase.jl module - Removed all @recipe function definitions from original source files - Removed numargs method for RuntimeGeneratedFunctions from utils.jl The plotting functionality is now only available when RecipesBase is explicitly loaded, maintaining backward compatibility while reducing the default dependency footprint. The RuntimeGeneratedFunctions support for numargs is similarly conditional. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Move Moshi usage from core dependencies to SciMLBaseMoshiExt - Replace @data/@match pattern matching with fallback struct implementations - Create clock_fallback.jl with basic clock functionality when Moshi not loaded - Provides 17.5% load time reduction (0.099s improvement from 0.567s to 0.468s) - Maintains full backward compatibility for users with advanced clocking needs - Extension automatically loads when Moshi is available, enabling pattern matching 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
AayushSabharwal
requested changes
Aug 3, 2025
|
oh it mixed this and a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves Moshi dependency from core deps to package extension, providing 17.5% load time reduction (0.099s improvement from 0.567s to 0.468s).
@data/@matchpattern matching with fallback struct implementationsSciMLBaseMoshiExtextension that automatically loads advanced pattern matching when Moshi is availableLoad Time Analysis
Before:
After:
Technical Details
@data/@matchusage from core toSciMLBaseMoshiExt.jlclock_fallback.jlwith simple struct-based clock implementationsTest Plan
ContinuousClock,PeriodicClock,SolverStepClock) create correctlyisclock,iscontinuous,issolverstepclock) work correctlyThis builds on PR #1092 (RecipesBase/RuntimeGeneratedFunctions extensions) for continued SciMLBase load time optimization.
🤖 Generated with Claude Code