Move LinearAlgebra.jl to extension #1096
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved LinearAlgebra dependency to weakdeps in Project.toml - Created SciMLBaseLinearAlgebraExt extension module - Moved all LinearAlgebra-dependent code to the extension: - Identity matrix (I) constant and default_identity_matrix() - has_non_trivial_mass_matrix() implementation - get_initial_values() for CheckInit algorithm - calculate_solution_errors\!() for ODE, DAE, and RODE solutions - Replaced direct LinearAlgebra references with extension-compatible stubs - Updated mass_matrix comparisons to use default_identity_matrix() This change reduces compilation overhead for users who don't need LinearAlgebra functionality, while preserving all existing functionality when LinearAlgebra is loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves LinearAlgebra.jl from a direct dependency to a package extension, reducing compilation overhead for users who don't need LinearAlgebra functionality.
Changes
Benefits
Testing
The extension loads correctly and provides LinearAlgebra functionality when the package is loaded. Some tests may need adjustment due to the extension loading mechanism.
Note: SparseArrays.jl was checked but no usage was found in the codebase, so no changes were needed for that package.