Skip to content

Conversation

@jClugstor
Copy link
Member

Checklist

  • [x ] Appropriate tests were added
  • [x ] Any code changes were done in a way that does not break public API
  • [x ] All documentation related to code changes were updated
  • [x ] The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • [x ] Any new documentation only uses public API

Additional context

Fixes interpolation for stripped solution objects, i.e. solution objects from strip_solution.

I'm not sure about doing struct ODENullFunction <: SciMLBase.AbstractODEFunction{false} end, but the inner constructor for ODEProblem doesn't allow f to be nothing. And the alternative seems to be changing the functors for ODEProblem. This also allows for stripped_solutions to keep some problem information. It might be good to add taking out the whole problem as an option as well?

@jClugstor
Copy link
Member Author

Actually, I can just make prob = (; p = nothing)

@jClugstor jClugstor marked this pull request as ready for review September 23, 2024 13:46
@ChrisRackauckas
Copy link
Member

Please update the downstream tests with this.

@ChrisRackauckas ChrisRackauckas merged commit 1e6720c into SciML:master Sep 23, 2024
40 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants