Skip to content

Fix _func_cache type promotion in remake #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
+8 −0
Merged

Fix _func_cache type promotion in remake #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/remake.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ function remake(
spec = specialization(func)
# retain properties of original function
props = getproperties(func)
forig = f

if f === missing || is_split_function(func)
# if no `f` is provided, create the same type of SciMLFunction
Expand Down Expand Up @@ -183,7 +184,14 @@ function remake(
if !(f2 isa Union{AbstractSciMLOperator, split_function_f_wrapper(T)})
f2 = split_function_f_wrapper(T){iip, spec}(f2)
end

props = @delete props.f2

if !ismissing(forig)
props = @delete props._func_cache
props = @insert props._func_cache = forig._func_cache
end

Copy link
Contributor

@github-actions github-actions bot Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

args = (args..., f2)
end
end
Expand Down
Loading