Fix type instability #989
Closed
Fix type instability #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Apr 13, 2025
Contributor
Author
|
It seems #985 is also fixed after this. |
| iip = isinplace(prob) | ||
|
|
||
| if build_initializeprob == Val{true} || build_initializeprob == true | ||
| if build_initializeprob isa Val{true} || build_initializeprob == true |
Member
There was a problem hiding this comment.
build_initializeprob defaults to Val{true} and Val{true} isa Val{true} == false so this won't run?
Member
There was a problem hiding this comment.
The other way to do it is build_initializeprob === Val{true}
Contributor
Author
There was a problem hiding this comment.
Doesn't help. Looks like the problem is inside the if, within remake_initialization_data::Any. I effectively just made it if false so it never ran.
Contributor
Author
|
I think SciML/ModelingToolkit.jl#3560 is really just a rediscovery of #985. Sorry for wasting your time, I thought I had narrowed this down to something simple ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SciML/ModelingToolkit.jl#3560.