Update PINNOptimizers Benchmarks #1148
Conversation
|
@ChrisRackauckas I fixed the PINNOptimizers benchmarks and it was running well locally but the tests seem to be running for 18 hours now. |
|
Like the other, force the latest versions and make sure the manifest resolves |
|
@ChrisRackauckas I have updated the PINNOptimizers benchmarks, resolved manifest and tested it locally. Everything works fine and gives the correct results |
|
I think this got stuck at line 140 and isn't progressing further |
|
Where exactly are you stuck? What's the code and what's the error? |
|
No. I wasn't stuck at any point, but the CI took a lot of time to complete like 41 hours. and yesterday it was stuck on processing line number 140 the whole day |
|
The CI is complete and the code outputs the results with no errors |
|
Manifest resolved too |
|
@ChrisRackauckas This is done. Can you please review this ?? I will work on fixing the other two of my remaining PRs won't take much time |
|
Yes looks good now! |
This PR certifies the completion of the two bnechmark sets by @ParamThakkar123 with the following PRs: * SciML/SciMLBenchmarks.jl#1148 * SciML/SciMLBenchmarks.jl#1160 * SciML/SciMLBenchmarks.jl#1159 It also adds two new benchmark sets that are in dire need of updates. As a monetary decision, requires 3 approvals. I approve.
2 participants
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.