Improve IdentityOperator and ScaledOperator actions #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
I slightly improved the
IdentityOperatorandScaledOperatoraction.More specifically, I removed the
update_coefficientsin theIdentityOperator, as it is constant by construction.I have also simplified the action of a
ScaledOpertator. The previous implementation was directly usingmul!, which I think it not always the case, asScaledOperatormay contain a more complex operator inL.L. So, I first update the coefficients ofL.λ, and then directly apply the operator actionL.L(w, v, u, p, t).After merging this PR (if accepted), could we release a new version? It is needed to add support in QuantumToolbox.jl of the new v1 version.