Skip to content

Fix StackOverFlowError on multiplication between ScalarOperator and UniformScalar #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Fix StackOverFlowError on multiplication between ScalarOperator and UniformScalar #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecebb0a
Fix StackOverfloxError on ScalarOperator-UniformScaling multiplication
albertomercurio Aug 12, 2025
86a5e22
Add tests
albertomercurio Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/scalar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,16 +379,14 @@ end
for T in SCALINGNUMBERTYPES[2:end]
@eval function Base.:*(α::ScalarOperator, x::$T)
if isconstant(α)
T2 = promote_type($T, eltype(α))
return ScalarOperator(convert(T2, α) * x, α.update_func)
return ScalarOperator(concretize(α) * x)
else
return ComposedScalarOperator(α, ScalarOperator(x))
end
end
@eval function Base.:*(x::$T, α::ScalarOperator)
if isconstant(α)
T2 = promote_type($T, eltype(α))
return ScalarOperator(convert(T2, α) * x, α.update_func)
return ScalarOperator(concretize(α) * x)
else
return ComposedScalarOperator(ScalarOperator(x), α)
end
Expand Down
5 changes: 5 additions & 0 deletions test/scalar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ K = 12
copy!(w, orig_w)
α(w, v, u, nothing, 0.0, a, b)
@test w ≈ a * (x * v) + b * orig_w

# Operations with UniformScalar
α = ScalarOperator(1)
@test α * I == α
@test α + I isa AddedScalarOperator
end

@testset "ScalarOperator Combinations" begin
Expand Down
Loading