Add fallback Base.copy method for AbstractSciMLOperator #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a fallback copy method for AbstractSciMLOperator that provides safe copying behavior for operators that don't have specific copy methods defined. This prevents issues when LinearSolve.jl tries to copy operators in the initialization path, addressing CI failures in LinearSolve.jl PR #763. The fallback method: - For convertible operators: Creates a new operator from the copied concrete representation - For non-convertible operators: Falls back to deepcopy as a last resort - Includes appropriate warnings when using fallback behavior This ensures all SciMLOperators have a copy method available, preventing MethodError exceptions when copy() is called on complex operator types. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The FunctionOperator copy method was attempting to copy L.u and deepcopy L.p even when they were nothing, which causes errors. This fixes the copy method to check if the values are nothing before attempting to copy them. Changes: - Check L.u !== nothing before calling copy(L.u) - Check L.p !== nothing before calling deepcopy(L.p) This prevents MethodError when copying FunctionOperators with nothing values for u or p parameters. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The issue was specifically in FunctionOperator's copy method trying to copy nothing values, not a missing fallback. Removing the unnecessary fallback method that was added earlier. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FunctionOperatorcopy method to properly handlenothingvalues foruandpparametersProblem
LinearSolve.jl PR #763 replaced
deepcopywithcopyin the initialization path to improve performance and enable trimming optimizations. However, theFunctionOperator.copymethod was attempting to callcopy(L.u)anddeepcopy(L.p)even whenL.uorL.pwerenothing, causingMethodErrorexceptions.Root Cause
The issue was in
src/func.jllines 450-451:This code checked if the fields were defined but didn't check if they were
nothingbefore attempting to copy them.Solution
Fixed the copy method to check for
nothingvalues before attempting to copy:Testing
nothingvalues for u and pBenefits
🤖 Generated with Claude Code