Fix type instabilities on complex AddedOperators and add new methods #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
Author
|
Any thoughts about it? |
| @assert !isempty(ops) | ||
| _check_AddedOperator_sizes(ops) | ||
| T = promote_type(eltype.(ops)...) | ||
| T = mapreduce(eltype, promote_type, ops) |
Member
There was a problem hiding this comment.
make sure this doesn't allocate? Usually mapreduce is expensive.
Contributor
Author
There was a problem hiding this comment.
I had to change it because the broadcasting was actually making type instabilities.
Member
There was a problem hiding this comment.
oh it's on a tuple, that works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
The code I added in the runtests fails using the master branch with Julia v1.10. Here I have fixed some type instabilities and added a few new methods for
AddedOperator, in order to simplify some operations.If this PR will be merged, releasing a new version would be appreciated.