Feature/custom structs backsolve adjoint #1292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've rebased this PR onto the latest master to resolve the merge conflicts. The rebased branch is available at: https://github.com/ChrisRackauckas-Claude/SciMLSensitivity.jl/tree/feature/custom_structs_backsolve_adjoint @simenhu To update your PR with the rebased changes, you can run: git remote add claude https://github.com/ChrisRackauckas-Claude/SciMLSensitivity.jl.git
git fetch claude feature/custom_structs_backsolve_adjoint
git checkout feature/custom_structs_backsolve_adjoint
git reset --hard claude/feature/custom_structs_backsolve_adjoint
git push --force origin feature/custom_structs_backsolve_adjointThe rebase resolved the following conflicts in
Co-Authored-By: Chris Rackauckas [email protected] |
2 tasks
Contributor
|
Opened a rebased version of this PR at #1335. |
Minor optimization: cache the result of isscimlstructure(p) in a local variable to avoid calling it twice in the hot _vecjacobian! path. Co-Authored-By: Chris Rackauckas <[email protected]>
Performance optimization: use the pre-cached wrapped function (pf) from S.diffcache.pf instead of calling repack_ode_function in every _vecjacobian! call. The function wrapping is already done during setup in adjoint_common.jl, so we can reuse it directly. This avoids: - Closure creation in the hot path - Calling repack inside the closure on every ODE evaluation Co-Authored-By: Chris Rackauckas <[email protected]>
…ions The closure was only defined for inplace signature (du, u, p, t), but out-of-place functions need (u, p, t) signature. Added isinplace parameter to generate the correct closure based on the function type. Co-Authored-By: Chris Rackauckas <[email protected]>
For some sensitivity algorithms (QuadratureAdjoint, etc.), pf is set to nothing in adjointdiffcache. Fall back to the original behavior of using SciMLBase.Void(f) for inplace or f for out-of-place when pf is nothing. Co-Authored-By: Chris Rackauckas <[email protected]>
simenhu
force-pushed
the
feature/custom_structs_backsolve_adjoint
branch
from
0e9e939 to
d7661ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
BacksolveAdjoint now works with SciMLStructures