Remove var=var keyword argument repetition in function calls #1315
+1,365
−1,981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhro
force-pushed
the
semicolons
branch
4 times, most recently
from
55e99eb to
c16c30d
Compare
Starting with Julia 1.5, `f(..., a=a, ...)` can be written as `f(...; a, ....)`
Member
|
tests fail |
Starting with Julia 1.5, `f(..., a=a, ...)` can be written as `f(...; a, ....)`. Also removes some trailing whitespace.
Member
|
All tests were passing on master, and |
Starting with Julia 1.5, `f(..., a=a, ...)` can be written as `f(...; a, ....)`. Also removes some trailing whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Additional context
Starting with Julia 1.5,
f(..., a=a, ...)can be written asf(...; a, ....), so I rewrite it as the second option for a bit more brevity since some keyword arguments have long names. This also helps clean up the code a little bit with less repetitive names, and some line widths where it flows a bit nicer.I have made no use of any LLM/generative AI tools in making the changes for this PR. This was entirely just mechanical changes out of some boredom, and as a detour from some doc updates, even though a PR like this generally fails me the Turing test.