Solve newprob so that output actually depends on input #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Going through the new example, I saw that the gradient returned
(nothing,); checked withForwardDiffand got all zeros; then just looked at the function value with different inputs, to see that it was indeed identical. It's hard to see this kind of mistake, but thenewprobwas never actually used; it just re-solved the original problem every time. With this change, I obtain consistent gradients withZygote,ForwardDiff, and evenFiniteDiff.