Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Pkg = "1.10, 1.11"
PrecompileTools = "1.2"
Primes = "0.5"
Random = "1.10, 1.11"
RationalFunctionFields = "0.2.2"
RationalFunctionFields = "0.2.3"
SpecialFunctions = "2"
SymbolicUtils = "4"
Symbolics = "7"
Expand Down
3 changes: 2 additions & 1 deletion src/parametrizations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ The function accepts the following optional arguments.

- `seed`: A float in the range from 0 to 1, random seed (default is `seed = 42`).
- `prob_threshold`: The probability of correctness (default is `prob_threshold = 0.99`).
- `loglevel`: the level of logs to be displayed (default is `Logging.Info`).

## Example

Expand Down Expand Up @@ -208,7 +209,7 @@ end

function _reparametrize_global(ode::ODE{P}; prob_threshold = 0.99, seed = 42) where {P}
Random.seed!(seed)
id_funcs = find_identifiable_functions(
id_funcs = _find_identifiable_functions(
ode,
with_states = true,
simplify = :strong,
Expand Down
4 changes: 2 additions & 2 deletions test/raw_generators.jl
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ import Groebner
gb = Groebner.groebner(eqs, ordering = Groebner.DegRevLex())
# GB is linear
@test length(gb) == length(gens(parent(eqs[1])))
expected = 9202476
expected = 9220151
str = join(map(string, eqs), ",")
@info "" length(str)
@test abs(length(str) - expected) / expected * 100 < 5

# Part 2: over Q
eqs = fractionfree_generators_raw(rff.mqs)[1]
expected = 21486079
expected = 14652203
str = join(map(string, eqs), ",")
@info "" length(str)
@test abs(length(str) - expected) / expected * 100 < 5
Expand Down