Skip to content

performance improvement in state_indexing #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

performance improvement in state_indexing #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/state_indexing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,11 @@ for (t1, t2) in [
return MultipleGetters(ContinuousTimeseries(), sym)
end
sym_arr = sym isa Tuple ? collect(sym) : sym
num_observed = count(x -> is_observed(sys, x), sym)
num_observed = 0
for s in sym
num_observed += is_observed(sys, s)
num_observed > 1 && break # exit early, we only need to know whether 0, 1, or more
end
if !is_time_dependent(sys)
if num_observed == 0 || num_observed == 1 && sym isa Tuple
return MultipleGetters(nothing, getu.((sys,), sym))
Expand All @@ -275,7 +279,6 @@ for (t1, t2) in [
ts_idxs = collect(ts_idxs)
end

num_observed = count(x -> is_observed(sys, x), sym)
if num_observed == 0 || num_observed == 1 && sym isa Tuple
getters = getu.((sys,), sym)
return MultipleGetters(ts_idxs, getters)
Expand Down
Loading