Skip to content

fix: fix stack overflow on remake_buffer of Dict #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: fix stack overflow on remake_buffer of Dict #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/remake.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ function remake_buffer(sys, oldbuffer::AbstractArray, idxs, vals)
return newbuffer
end

# We don't support `Dict`s as value providers. If we get a `Dict`,
# assume it is non-symbolic.
function remake_buffer(sys, oldbuffer::Dict, idxs, vals)
return Dict(idxs .=> vals)
end

remake_buffer(sys, ::Nothing, idxs, vals) = nothing

function remake_buffer(sys, oldbuffer, idxs, vals)
Expand Down
9 changes: 9 additions & 0 deletions test/remake_test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,12 @@ for (buf, newbuf, idxs, vals) in [
end

@test isnothing(remake_buffer(sys, nothing, [], []))

@testset "`remake_buffer` with `Dict`" begin
sys = nothing
buf = Dict("a" => 1, "b" => 2)
buf2 = remake_buffer(sys, buf, collect(keys(buf)), collect(values(buf)))
@test isequal(buf, buf2)
buf2 = remake_buffer(sys, buf, buf)
@test isequal(buf, buf2)
end
Loading