Restructure and Nim type wrappers for inq and some inq_dim functions#4
Open
hendrikgit wants to merge 3 commits intoSciNim:masterfrom
Open
Restructure and Nim type wrappers for inq and some inq_dim functions#4hendrikgit wants to merge 3 commits intoSciNim:masterfrom
hendrikgit wants to merge 3 commits intoSciNim:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to split the functions for dimensions, variables and attributes into their own modules. That is what the new structure is about. I think it is similar to nimhdf5 but I keep some functions in the main file, at least for now.
The variables and attributes will come in a later commit or PR.
My plan at the moment is to write what I called "Nim type wrappers" for the procs that bind to the C functions, at least some of them, but otherwise keep them the same. Then implement a higher level API on top of that.
I did add a few procs though for added convenience that differ from the C bindings (don't exist there) but are not really the high level API I want to eventually write either. At the moment I put them after a comment in the code.
Maybe you have a suggestion on where to put those or how to separate them? Or maybe I should just not do that and come up with a good high level API (which I want to do anyway) and skip these half measures?
I'm not clear on when it is better to use tuple and when object. Specifically in this PR in this proc.