Skip to content

[CI Bot] environment lockfiles auto-update#747

Closed
scitools-ci[bot] wants to merge 1 commit intomainfrom
auto-update-lockfiles
Closed

[CI Bot] environment lockfiles auto-update#747
scitools-ci[bot] wants to merge 1 commit intomainfrom
auto-update-lockfiles

Conversation

@scitools-ci
Copy link
Contributor

@scitools-ci scitools-ci bot commented Jan 10, 2026

Lockfiles updated to the latest resolvable environment.

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

@pp-mo
Copy link
Member

pp-mo commented Jan 12, 2026

I think this relates to a change in cf-time 1.6.4 ->1.6.5
and probably it was this issue fixed here

Probably, we need to accept that this was wrong before, and change the CML to reflect the new result.
But I'm pausing until I get time to consider this properly -- it could be an error introduced, rather than an intended change from the fix

@scitools-ci scitools-ci bot force-pushed the auto-update-lockfiles branch from 6c03e27 to cfabe06 Compare January 17, 2026 00:27
@scitools-ci scitools-ci bot force-pushed the auto-update-lockfiles branch from cfabe06 to 5c66046 Compare January 24, 2026 00:27
@trexfeathers
Copy link
Contributor

I think this relates to a change in cf-time 1.6.4 ->1.6.5 and probably it was this issue fixed here

Probably, we need to accept that this was wrong before, and change the CML to reflect the new result. But I'm pausing until I get time to consider this properly -- it could be an error introduced, rather than an intended change from the fix

Have confirmed. During the failing test, date2num() in the below code is returning a number exactly 48 hours - 2 days - different to what it was previously. This is despite all the arguments remaining the same:

def phenomenon_points(self, time_unit):
"""Return the phenomenon time points.
As offsets from the epoch time reference, measured in appropriate time units.
"""
time_reference = "%s since epoch" % time_unit
return float(
cf_units.date2num(
self._phenomenonDateTime, time_reference, cf_units.CALENDAR_GREGORIAN
)
)

That precisely matches the description of the bug, where operating on non-proleptic-gregorian datetimes was incorrectly relying on the default Python datetime handling rather than anything specialised. We even have the same calendar as the examples in the bug report (standard/gregorian).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants