Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Oct 8, 2025

Closes #6740

TBH this might have targetted "save_dataless" #6739 instead.
But now it can just wait till after that one

Note:

Since we now have the abililty to save+load dataless cubes, this also updates make_gridcube to be dataless

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.38%. Comparing base (9c06cca) to head (58aca88).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
lib/iris/cube.py 0.00% 1 Missing ⚠️
lib/iris/util.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6741      +/-   ##
==========================================
+ Coverage   90.29%   90.38%   +0.08%     
==========================================
  Files          91       91              
  Lines       24656    24743      +87     
  Branches     4618     4638      +20     
==========================================
+ Hits        22264    22364     +100     
+ Misses       1620     1608      -12     
+ Partials      772      771       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pp-mo pp-mo marked this pull request as ready for review October 9, 2025 09:06
@pp-mo pp-mo mentioned this pull request Oct 9, 2025
@pp-mo pp-mo marked this pull request as draft October 10, 2025 09:27
@pp-mo
Copy link
Member Author

pp-mo commented Oct 10, 2025

Status Update Fri 2023-10-10

I'm currently using this branch to add some more extensive documentation, since I felt I needed a decent location to describe the properties of merging with dataless cubes.

Also, I want to at least refer to #6739

Hence put this in draft for a while...

@pp-mo pp-mo marked this pull request as ready for review October 22, 2025 18:07
Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Patrick 👍🏼
Just a few comments.

@pp-mo
Copy link
Member Author

pp-mo commented Oct 30, 2025

Thanks for latest @stephenworsley.
Hopefully feba264 addresses those.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephenworsley stephenworsley merged commit 2ef5940 into SciTools:main Oct 30, 2025
22 checks passed
@pp-mo
Copy link
Member Author

pp-mo commented Oct 30, 2025

Brilliant, thanks @stephenworsley
I was so keen to get this in, for the docs improvements.
(and I really should have submitted that separately!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Support dataless cubes in merge

3 participants