- 
                Notifications
    You must be signed in to change notification settings 
- Fork 297
Merge dataless #6741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dataless #6741
Conversation
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #6741      +/-   ##
==========================================
+ Coverage   90.29%   90.38%   +0.08%     
==========================================
  Files          91       91              
  Lines       24656    24743      +87     
  Branches     4618     4638      +20     
==========================================
+ Hits        22264    22364     +100     
+ Misses       1620     1608      -12     
+ Partials      772      771       -1     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| Status Update Fri 2023-10-10I'm currently using this branch to add some more extensive documentation, since I felt I needed a decent location to describe the properties of merging with dataless cubes. Also, I want to at least refer to #6739 Hence put this in draft for a while... | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Patrick 👍🏼
Just a few comments.
| Thanks for latest @stephenworsley. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| Brilliant, thanks @stephenworsley | 
Closes #6740
TBH this might have targetted "save_dataless" #6739 instead.
But now it can just wait till after that one
Note:
Since we now have the abililty to save+load dataless cubes, this also updates make_gridcube to be dataless