Added dataless rolling window, _intersect #6757
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6757 +/- ##
==========================================
+ Coverage 90.29% 90.31% +0.01%
==========================================
Files 91 91
Lines 24656 24665 +9
Branches 4618 4620 +2
==========================================
+ Hits 22264 22277 +13
+ Misses 1620 1618 -2
+ Partials 772 770 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lib/iris/cube.py
Outdated
| """ | ||
| if self.is_dataless(): | ||
| raise iris.exceptions.DatalessError("intersection") | ||
| # if self.is_dataless(): |
There was a problem hiding this comment.
Remember to nuke this. 🙂
|
|
||
| def test_weights_arr(self): | ||
| @pytest.mark.parametrize("dataless", [True, False]) | ||
| def test_weights_arr(self, dataless): |
There was a problem hiding this comment.
This test doesn't assert anything for dataless cubes. Perhaps don't parametrize it for dataless?
There was a problem hiding this comment.
Actually, that's not true as it is asserting the units.
However, the test is for the "weights array", so I still think it is a pointless test for dataless.
|
|
||
| def test_weights_cube(self): | ||
| @pytest.mark.parametrize("dataless", [True, False]) | ||
| def test_weights_cube(self, dataless): |
There was a problem hiding this comment.
Same as previous comment - this test doesn't assert anything for dataless cubes.
ESadek-MO
changed the title
2 participants
Interpolation and regridding are both quite involved. For completion sake, I would've liked to get interpolation in, but I don't think it's worth the time it would take to get it right. Some of the underlying logic just doesn't work with dataless cubes, and would need chasing around the place.
So for now, I think this is it for single operations. If there's a call in the future for interpolate or regridding (the latter seems particularly unlikely), then we can work towards them then.