Convert fileformats/nc_load_rules to pytest #6896
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6896 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 91 91
Lines 24822 24822
Branches 4656 4656
=======================================
Hits 22385 22385
Misses 1669 1669
Partials 768 768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HGWright
left a comment
HGWright
left a comment
There was a problem hiding this comment.
Just one thing to change in a few places, from the ruff check --select PT then this is good to go.
| def mock_cf_data_var(): | ||
| yield mock.Mock( | ||
| def mock_cf_data_var(mocker): | ||
| yield mocker.Mock( |
There was a problem hiding this comment.
From ruff check --select PT replace yield with return
| ) | ||
| engine = mock.Mock(cube=Cube([23]), cf_var=cf_var, filename="foo.nc") | ||
| engine = mocker.Mock(cube=Cube([23]), cf_var=cf_var, filename="foo.nc") | ||
| yield engine |
There was a problem hiding this comment.
From ruff check --select PT replace yield with return
| yield mock.Mock( | ||
| cube=mock.Mock(), | ||
| def mock_engine(mock_cf_data_var, mocker): | ||
| yield mocker.Mock( |
There was a problem hiding this comment.
From ruff check --select PT replace yield with return
| ) | ||
| engine = mock.Mock(cube=Cube([23]), cf_var=cf_var, filename="foo.nc") | ||
| engine = mocker.Mock(cube=Cube([23]), cf_var=cf_var, filename="foo.nc") | ||
| yield engine |
There was a problem hiding this comment.
From ruff check --select PT replace yield with return
| def mock_cf_data_var(): | ||
| yield mock.Mock( | ||
| def mock_cf_data_var(mocker): | ||
| yield mocker.Mock( |
There was a problem hiding this comment.
From ruff check --select PT replace yield with return
| yield mock.Mock( | ||
| cube=mock.Mock(attributes={}), | ||
| def mock_engine(mock_cf_data_var, mocker): | ||
| yield mocker.Mock( |
There was a problem hiding this comment.
From ruff check --select PT replace yield with return
2 participants
🚀 Pull Request
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: