Prototype idea for using DatasetWrapper in the NetCDF Proxies
#6903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
added
the
benchmark_this
trexfeathers
commented
Jan 21, 2026
|
|
||
|
|
||
| class NcParallelError(IrisError): | ||
| """Raised when a netCDF operation fails due to parallel I/O issues.""" |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| """Raised when a netCDF operation fails due to parallel I/O issues.""" | |
| """Raised when a NetCDF operation fails due to parallel I/O issues.""" |
trexfeathers
commented
Jan 21, 2026
Contributor
Author
There was a problem hiding this comment.
Could consider moving NetCDFDataProxy and NetCDFWriteProxy back into loader.py and saver.py
Contributor
⏱️ Performance Benchmark Report: d472a9aPerformance shiftsFull benchmark resultsGenerated by GHA run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Since #5095 - 2022 - it now seems much more difficult to replicate the
not a valid IDerror. This is even true if I check out Iris 3.5 and try it there, even when running large numbers of operations on a cluster. Expect this is due to hardware improvements.So I think that the awkwardness of not using
DatasetWrapperwithinNetCDFDataProxyandNetCDFWriteProxymight not be worth it any more. I wanted to capture my thoughts quickly while they were fresh in my head.The use of a custom exception class with a meaningful error message should make it much easier for users to handle
not a valid IDon the rare occasions it does occur, as well as encouraging users to contact us if they see it more often than expected.To do
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: