-
Notifications
You must be signed in to change notification settings - Fork 43
[MS] Remade file operations #11933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MS] Remade file operations #11933
Conversation
44c4315 to
a3a87c1
Compare
c03860f to
dfb0c79
Compare
f49aa53 to
310cb99
Compare
Ironicbay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, this is very impressive. The imports are considerably faster and the system is robust and handles many cases extremely well, congrats!!
When having a large number of current operations (in my case 200 copies and 40 imports), the GUI slows down considerably. This was tested on our testbed on the web client, what I observed:
- Navigating through the workspace works even if slow
- I can create other workspaces and start operations there
- Any other page breaks:
- Devices page shows no device
- Authentication page fails to retrieve information
Users,InvitationsandInformation pagesare blank
Relevant output:
chunk-6T6A37T5.js?v=2199de53:1462 Uncaught (in promise) Error: Missing required param "handle"
at Object.stringify (chunk-6T6A37T5.js?v=2199de53:1462:22)
at Object.resolve (chunk-6T6A37T5.js?v=2199de53:1628:22)
at resolve (chunk-6T6A37T5.js?v=2199de53:2056:34)
at pushWithRedirect (chunk-6T6A37T5.js?v=2199de53:2116:46)
at push (chunk-6T6A37T5.js?v=2199de53:2088:12)
at Object.replace (chunk-6T6A37T5.js?v=2199de53:2091:12)
at navigateTo (navigation.ts:29:18)
at switchPage (MyProfilePage.vue:374:9)
I don't know how relevant this is considering I've been torturing the poor thing for hours at this point.
Also, not sure if this is relevant on dev mode, but there's no warning when trying to close the page while operations are running.
| "importMultiplesFiles": "Importing {count}", | ||
| "importFilesAction": "Import files", | ||
| "importFolderAction": "Import a folder", | ||
| "title": "Background tasks", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not rename the title to File operations / Opérations de fichiers? Background tasks feels broader than this.
If such a change is made, we would have to switch from Task to Operation in other relevant locales.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File operation seems to be a dev term. I prefer to use Background tasks instead.
client/src/locales/fr-FR.json
Outdated
| "inProgress": "En cours", | ||
| "done": "Terminés", | ||
| "failed": "Échoués" | ||
| "failed": "Échoués", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "failed": "Échoués", | |
| "failed": "Échouées", |
Co-Authored-By: fabienSvstr <fabien.sevestre@scille.fr>
8325351 to
da4459d
Compare
Closes #9881
This is a total rework of file operations: how files are imported, copied, moves, restored and downloaded, but also how those operations are displayed in the GUI.
A few goals:
folder (2)instead of merging the two foldersAll those goals are achieved, and then more:
It does come with some drawbacks:
And a few things that weren't changed because of complexity: