[MS] Client Area Style Miscellaneous (Saas only) #11996
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienSvtr
force-pushed
the
ms-client-area-style-miscellaneous
branch
from
4af4a88 to
818f04b
Compare
fabienSvtr
changed the title
fabienSvtr
force-pushed
the
ms-client-area-style-miscellaneous
branch
from
bb9fc99 to
6de1a87
Compare
Ironicbay
requested changes
Jan 8, 2026
Contributor
Ironicbay
left a comment
Ironicbay
left a comment
There was a problem hiding this comment.
Organization statistics page is not done yet
| @click="isSidebarMenuVisible ? hideSidebarMenu() : resetSidebarMenu()" | ||
| :image="SidebarToggle" | ||
| /> | ||
| <ion-menu-toggle v-if="!isMobile() && isSmallDisplay"> |
Contributor
There was a problem hiding this comment.
Why !isMobile()? Wouldn't we want this toggle on mobile as well?
Contributor
There was a problem hiding this comment.
After selecting an organization on the statistics page, there's no indication of it in small display (it's displayed in the sidebar on large display).
I would either add the organization name somewhere visible like below the header, or add the switch organization popover somewhere in the page. But as I specified in my first comment, the organization-specific statistics page is not done yet
Comment on lines
+368
to
+372
| const filteredOrganizations = computed(() => | ||
| searchQuery.value.trim() | ||
| ? props.organizations.filter((org) => org.name.toLowerCase().includes(searchQuery.value.toLowerCase().trim())) | ||
| : props.organizations, | ||
| ); |
Contributor
There was a problem hiding this comment.
suggestion: Use if/else rather than ternaries for code clarity.
Suggested change
| const filteredOrganizations = computed(() => | |
| searchQuery.value.trim() | |
| ? props.organizations.filter((org) => org.name.toLowerCase().includes(searchQuery.value.toLowerCase().trim())) | |
| : props.organizations, | |
| ); | |
| const filteredOrganizations = computed(() => { | |
| const query = searchQuery.value.trim(); | |
| if (query) { | |
| return props.organizations.filter((org) => org.name.toLowerCase().includes(query.toLocaleLowerCase())); | |
| } | |
| return props.organizations; | |
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included:
Client.area.responsive.-.Saas.mov
closes #10342, closes #11998