catalyst: Rename to catalyst-browser #14652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Author
|
Recreated PR because the old one was broken. |
Contributor
|
All changes look good. Wait for review from human collaborators. catalyst-browser
|
rasa
reviewed
Dec 29, 2024
Member
rasa
left a comment
rasa
left a comment
There was a problem hiding this comment.
@jdev082 Renames concern me, as users who have this installed, will not be informed of the rename. The package will simply disappear.
Is there some way we can alert the user to the rename? For example, we create a new catalyst-browser, and change catalyst.json to require it as a dependency? I haven't tested that, so I'm not sure that's gonna work for them.
Or at least add a note in the old version's description and notes, that says it's been renamed, and to uninstall the old, and reinstall the new?
Signed-off-by: jdev082 <jdev082@jdev.eu.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
catalystpackage tocatalyst-browserto be more consistent with upstream changes and other software repositories.