github@3.4.16: Switch to github releases #14768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All changes look good. Wait for review from human collaborators. github
|
aliesbelik
force-pushed
the
github-fix
branch
from
6f31700 to
9a1c9a6
Compare
aliesbelik
changed the title
Collaborator
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. github
|
aliesbelik
changed the title
Collaborator
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. github
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the current version of manifest uses GH to check new version but another source as (unversioned) download link it regularly results in hash check failed issues after version update (see history of commits) when a new release has already been published, but the corresponding binary has not yet been uploaded to the site.
Looks like using GH release artifacts will fix this issue.
This PR:
switches download/autoupdate urls to use GH release artifacts;
uses .nupkg instead of .exe to avoid additional extraction via
pre_install;adds hash autoupdate.
Use conventional PR title:
<manifest-name[@version]|chore>: <general summary of the pull request>I have read the Contributing Guide