tor-browser@14.5.5: Fix by mitigating Scoop issue with pre_install logic
#14886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-l-a-v
changed the title
pre_install logic
Contributor
|
All changes look good. Wait for review from human collaborators. tor-browser
|
Contributor
Author
|
/verify |
3 tasks
Contributor
|
All changes look good. Wait for review from human collaborators. tor-browser
|
Contributor
Author
|
Added to my bucket while we wait for this PR to be reviewed: Example use, name the bucket what you want. I call it PS > scoop bucket add orb https://github.com/o-l-a-v/scoop-bucket
PS > scoop uninstall tor-browser
PS > scoop install orb/tor-browser |
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. tor-browser
|
o-l-a-v
changed the title
pre_install logicpre_install logic
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. tor-browser
|
o-l-a-v
changed the title
pre_install logicpre_install logic
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. tor-browser
|
Contributor
Author
|
Scoop v0.5.3 is out with a fix to this, so I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Scoop has a known bug where it messes up install if nested folders has the same name.
This has been fixed in a PR, but Scoop has not yet been bumped to include it.
While we wait we might instead mitigate the issue by using
pre_installlogic?Added to my own bucket while we wait for PR to be reviewed
Added to my bucket while we wait for this PR to be reviewed:
Example use, name the bucket what you want. I call it
orb.Related
Closes #13324
Relates to:
Expand-7zipArchiveonly delete temp dir /$extractDirif it is empty Scoop#6092Other
<manifest-name[@version]|chore>: <general summary of the pull request>