Skip to content

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Mar 11, 2025

BREAKING CHANGE:

  • Will not use $env:APPDATA\Bitwarden for user data anymore.
  • Will not attempt to copy user data from elsewhere.

Builds on closed PRs by @FlawlessCasual17:

Changes from PRs above:

What I added:

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

bitwarden

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@jasongodev
Copy link
Contributor

I was tagged in the previously closed PR that uses portable version of the Bitwarden. Looking at this new PR, it looks okay to me.

@pratikpc
Copy link
Contributor

Is it possible in Scoop to add default arguments to the bin exe generated?

I do not use Bitwarden so am just curious if without it, this would not end up being a breaking change?

@pratikpc
Copy link
Contributor

Also if possible can't the persist directory name be retained?

Otherwise, this would end up as a bigger breaking change

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Mar 16, 2025

The persist dir has no function as of now, so changing it is not a breaking change.

@pratikpc
Copy link
Contributor

pratikpc commented Mar 16, 2025

@o-l-a-v but in portable mode is that not the user data directory?

Sorry I am not a user of Bitwarden Client but I read the code here

https://github.com/bitwarden/clients/blob/fdcb6ff7a2fbefeccbaf5b5bcd4243f8fb84c09a/apps/desktop/src/main.ts#L94

With Electron, the environment variable is set for portable builds.

https://www.electron.build/nsis.html#portable

Bitwarden has a portable target

https://github.com/bitwarden/clients/blob/fdcb6ff7a2fbefeccbaf5b5bcd4243f8fb84c09a/apps/desktop/electron-builder.json#L86

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Mar 16, 2025

Damn, you're probably right @pratikpc. I read these previous discussions, but got it wrong.

Probably best to keep the persist directory name, I agree.

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Mar 16, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

bitwarden

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants