-
Notifications
You must be signed in to change notification settings - Fork 1.6k
bitwarden@2025.2.1: Make portable #15053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
All changes look good. Wait for review from human collaborators. bitwarden
|
|
I was tagged in the previously closed PR that uses portable version of the Bitwarden. Looking at this new PR, it looks okay to me. |
|
Is it possible in Scoop to add default arguments to the bin exe generated? I do not use Bitwarden so am just curious if without it, this would not end up being a breaking change? |
|
Also if possible can't the persist directory name be retained? Otherwise, this would end up as a bigger breaking change |
|
The persist dir has no function as of now, so changing it is not a breaking change. |
|
@o-l-a-v but in portable mode is that not the user data directory? Sorry I am not a user of Bitwarden Client but I read the code here With Electron, the environment variable is set for portable builds. https://www.electron.build/nsis.html#portable Bitwarden has a portable target |
|
Damn, you're probably right @pratikpc. I read these previous discussions, but got it wrong.
Probably best to keep the persist directory name, I agree. |
|
/verify |
|
All changes look good. Wait for review from human collaborators. bitwarden
|
BREAKING CHANGE:
$env:APPDATA\Bitwardenfor user data anymore.Builds on closed PRs by @FlawlessCasual17:
pre_install, addedarchitecture, and addedautoupdatehash extraction #10652Changes from PRs above:
nsis.7zgiven the OS architecture, cuts download size to 1/3.What I added:
"bin": "Bitwarden.exe"."shortcuts":: Use--user-data-dir=\"$dir\\data\"to have Bitwarden installed by Scoop keep its data inside Scoop.Persistdata.bitwarden-appdata, thanks bitwarden@2025.2.1: Make portable #15053 (comment).<manifest-name[@version]|chore>: <general summary of the pull request>