-
Notifications
You must be signed in to change notification settings - Fork 1.6k
(chore): Add CHROME_EXECUTABLE env for Chromium-based browsers
#15067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your changes do not pass checks. chromium
supermium
thorium
ungoogled-chromium
|
|
i will trying to fix supermium checkver in another PR. |
|
Bump |
WalkthroughAdded or updated top-level Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with chromium
supermium
thorium
ungoogled-chromium
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. chromium
supermium
thorium
ungoogled-chromium
|
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
CHROME_EXECUTABLE env for chrome based browserCHROME_EXECUTABLE env for Chromium-based browsers
<manifest-name[@version]|chore>: <general summary of the pull request>Relates to ScoopInstaller/Scoop#6299
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.