Skip to content

Conversation

@cscnk52
Copy link
Contributor

@cscnk52 cscnk52 commented Mar 14, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Relates to ScoopInstaller/Scoop#6299

Summary by CodeRabbit

  • Bug Fixes

    • Fixed Thorium executable path so the launcher locates the Thorium binary correctly.
  • Chores

    • Added a CHROME_EXECUTABLE environment variable for Chromium, Ungoogled Chromium, Supermium and related variants to improve launcher compatibility and executable resolution.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link
Contributor

Your changes do not pass checks.

chromium

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

supermium

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

thorium

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ungoogled-chromium

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@cscnk52
Copy link
Contributor Author

cscnk52 commented Mar 14, 2025

i will trying to fix supermium checkver in another PR.

@cscnk52
Copy link
Contributor Author

cscnk52 commented Sep 21, 2025

Bump

@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Walkthrough

Added or updated top-level env_set entries in four browser manifest JSON files to declare CHROME_EXECUTABLE; three manifests set it to "$dir\\chrome.exe", and Thorium's path was changed to "$dir\\bin\\thorium.exe". No other logic, control flow, or public declarations were modified.

Changes

Cohort / File(s) Summary
Env var additions
bucket/chromium.json, bucket/supermium.json, bucket/ungoogled-chromium.json
Added top-level env_set with CHROME_EXECUTABLE set to "$dir\\chrome.exe"
Executable path update
bucket/thorium.json
Updated env_set.CHROME_EXECUTABLE value from "$dir\\thorium.exe" to "$dir\\bin\\thorium.exe"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify JSON syntax and correct escaping of backslashes in each file.
  • Ensure there are no duplicate top-level keys or conflicting env_set entries.
  • Confirm thorium.exe location under bin matches the package layout.

Poem

🐰 I hop through manifests, tidy and fleet,
CHROME_EXECUTABLE set for installs to meet,
Thorium now rests in bin snug and trim,
Small changes, quick steps — a rabbit's bright whim,
Hooray for paths that lead to a win!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description includes both required checklist items completed and a clear reference to the related discussion, though it lacks specific details about affected files or implementation approach.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and specifically describes the main change: adding CHROME_EXECUTABLE environment variables to Chromium-based browser manifests.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ScoopInstaller ScoopInstaller deleted a comment from github-actions bot Dec 11, 2025
@z-Fng
Copy link
Member

z-Fng commented Dec 11, 2025

/verify

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

chromium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

supermium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

thorium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ungoogled-chromium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng
Copy link
Member

z-Fng commented Dec 11, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

chromium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

supermium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

thorium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ungoogled-chromium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng changed the title chore: add CHROME_EXECUTABLE env for chrome based browser (chore): Add CHROME_EXECUTABLE env for Chromium-based browsers Dec 11, 2025
@z-Fng z-Fng merged commit ca0bb3f into ScoopInstaller:master Dec 11, 2025
3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 22, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants