Skip to content

Conversation

@haussmann
Copy link
Contributor

@haussmann haussmann commented Dec 17, 2025

Vendor site has removed all references to this software and switched to an online-only model.
Last and only update of this softrware was in November 2022.

I believe this software should be deprecated.

Relates to #16379

Summary by CodeRabbit

  • Documentation
    • Added a deprecation notice to a deprecated resource, including vendor status and last-updated date.
    • The notice is metadata-only and does not change existing fields or runtime behavior.
    • No functional changes — only formatting normalization of the metadata file; review effort estimated low.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Walkthrough

Normalized formatting in deprecated/b1.json (whitespace/line-prefix adjustments) without any functional or data changes to the JSON content.

Changes

Cohort / File(s) Change Summary
Formatting normalization
deprecated/b1.json
Adjusted JSON formatting/line prefixes (leading-minus lines replaced by equivalent plus lines). No changes to keys, values, structure, or exported declarations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-file, non-functional formatting-only change
  • No logic, schema, or compatibility implications

Poem

🐰 I straightened a line, kept every part,
A tiny tidy tweak from the heart,
Nothing broken, nothing new to mend,
A hush, a nibble, and then I hop on, friend. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'b1: Deprecate manifest' clearly summarizes the main change: deprecating the b1 manifest file. It is concise, specific, and directly related to the changeset.
Description check ✅ Passed The PR description includes all required elements: a clear justification for the deprecation, a reference to the related issue (#16379), and both required checklist items marked as completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff4d122 and ceb82ca.

📒 Files selected for processing (1)
  • deprecated/b1.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • deprecated/b1.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e7295f and 65a07cf.

📒 Files selected for processing (1)
  • deprecated/b1.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.

Applied to files:

  • deprecated/b1.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (1)
deprecated/b1.json (1)

2-5: Good deprecation approach: clear messaging while preserving manifest functionality.

The "##" metadata key at the top is the appropriate convention for Scoop manifests, and the deprecation notice clearly communicates the vendor's transition and last update timeline without breaking existing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant