Skip to content

Conversation

@haussmann
Copy link
Contributor

@haussmann haussmann commented Dec 18, 2025

  • Verified there are no open issues for this application
  • Verified there are no open pull requests for this application

Relates to #16379

Updates manifest for application:

Fixes checkver

Test result:

PS C:\Users\WDAGUtilityAccount\Desktop\ScoopExtras> .\bin\checkver.ps1 imo-messenger
imo-messenger: 1.5.2.3 (scoop version is 1.5.1.8) autoupdate available

Confirmed autoupdate:

PS C:\Users\WDAGUtilityAccount\Desktop\ScoopExtras> .\bin\checkver.ps1 -App imo-messenger -Update
imo-messenger: 1.5.2.3 (scoop version is 1.5.1.8) autoupdate available
Autoupdating imo-messenger
DEBUG[1766064065.77808] [$updatedProperties] = [url hash] -> C:\Users\WDAGUtilityAccount\scoop\apps\scoop\current\lib\autoupdate.ps1:491:5
DEBUG[1766064065.82546] $substitutions (hashtable) -> C:\Users\WDAGUtilityAccount\scoop\apps\scoop\current\lib\autoupdate.ps1:221:5
DEBUG[1766064065.82546] $substitutions.$buildVersion                  3                                                                                                                                         
DEBUG[1766064065.82546] $substitutions.$match1                        1.5.2.3                                                                                                                                   
DEBUG[1766064065.82546] $substitutions.$preReleaseVersion             1.5.2.3                                                                                                                                   
DEBUG[1766064065.82546] $substitutions.$version                       1.5.2.3                                                                                                                                   
DEBUG[1766064065.82546] $substitutions.$patchVersion                  2                                                                                                                                         
DEBUG[1766064065.82546] $substitutions.$urlNoExt                      https://static-web.imoim.net/as/indigo-static/winapp/1.5.2.3/ImoSetup_1.5.2.3_Release                                                     
DEBUG[1766064065.82546] $substitutions.$dotVersion                    1.5.2.3                                                                                                                                   
DEBUG[1766064065.82546] $substitutions.$cleanVersion                  1523                                                                                                                                      
DEBUG[1766064065.82546] $substitutions.$underscoreVersion             1_5_2_3                                                                                                                                   
DEBUG[1766064065.82546] $substitutions.$minorVersion                  5                                                                                                                                         
DEBUG[1766064065.82546] $substitutions.$url                           https://static-web.imoim.net/as/indigo-static/winapp/1.5.2.3/ImoSetup_1.5.2.3_Release.exe                                                 
DEBUG[1766064065.82546] $substitutions.$majorVersion                  1                                                                                                                                         
DEBUG[1766064065.82546] $substitutions.$matchTail                     .3                                                                                                                                        
DEBUG[1766064065.82546] $substitutions.$basenameNoExt                 ImoSetup_1.5.2.3_Release                                                                                                                  
DEBUG[1766064065.82546] $substitutions.$basename                      ImoSetup_1.5.2.3_Release.exe                                                                                                              
DEBUG[1766064065.82546] $substitutions.$dashVersion                   1-5-2-3                                                                                                                                   
DEBUG[1766064065.82546] $substitutions.$baseurl                       https://static-web.imoim.net/as/indigo-static/winapp/1.5.2.3                                                                              
DEBUG[1766064065.82546] $substitutions.$matchHead                     1.5.2                                                                                                                                     
DEBUG[1766064065.88904] $hashfile_url = $null -> C:\Users\WDAGUtilityAccount\scoop\apps\scoop\current\lib\autoupdate.ps1:224:5
Downloading ImoSetup_1.5.2.3_Release.exe to compute hashes!
ImoSetup_1.5.2.3_Release.exe (58.7 MB) [==============================================================================================================================================================] 100%
Computed hash: 80a53fcf5b06a5c903a080e54b5a9f6d5c38b8e1f2dbfe6a82527c0eb4b14329
Writing updated imo-messenger manifest

Confirmed Virustotal OK

https://www.virustotal.com/gui/url/bfa8733bd737b7da73311823103fab3b73e146dae5a87260f2a711654e8336dc
Everything ok, SHA-256 matches as well.

Confirmed update is working:

PS C:\Users\WDAGUtilityAccount\Desktop\ScoopExtras> scoop update imo-messenger
imo-messenger: 1.5.1.8 -> 1.5.2.3
Updating one outdated app:
Updating 'imo-messenger' (1.5.1.8 -> 1.5.2.3)
ERROR The following instances of "imo-messenger" are still running. Close them and try again.

Handles  NPM(K)    PM(K)      WS(K)     CPU(s)     Id  SI ProcessName
-------  ------    -----      -----     ------     --  -- -----------
    145      11     1768       7812       0.00   2100   1 crashpad_handler
    991     101    58516     116732       4.53   2000   1 ImoDesktopApp



Running process detected, skip updating.
PS C:\Users\WDAGUtilityAccount\Desktop\ScoopExtras> scoop update imo-messenger
imo-messenger: 1.5.1.8 -> 1.5.2.3
Updating one outdated app:
Updating 'imo-messenger' (1.5.1.8 -> 1.5.2.3)
Downloading new version
Loading ImoSetup_1.5.2.3_Release.exe from cache
Checking hash of ImoSetup_1.5.2.3_Release.exe ... ok.
Running pre_uninstall script...done.
Uninstalling 'imo-messenger' (1.5.1.8)
Unlinking ~\scoop\apps\imo-messenger\current
Installing 'imo-messenger' (1.5.2.3) [64bit] from 'C:\Users\WDAGUtilityAccount\Desktop\ScoopExtras\bucket\imo-messenger.json'
Loading ImoSetup_1.5.2.3_Release.exe from cache
Running installer script...done.
Linking ~\scoop\apps\imo-messenger\current => ~\scoop\apps\imo-messenger\1.5.2.3
Creating shortcut for imo Messenger (ImoDesktopApp.exe)
Persisting data
Persisting Logs
'imo-messenger' (1.5.2.3) was installed successfully!

Confirmed clean installation is working:

PS C:\Users\WDAGUtilityAccount\Desktop\ScoopExtras> scoop install .\bucket\imo-messenger.json
Installing 'dark' (3.14.1) [64bit] from 'main' bucket
Loading dark-3.14.1.zip from cache
Checking hash of dark-3.14.1.zip ... ok.
Extracting dark-3.14.1.zip ... done.
Linking ~\scoop\apps\dark\current => ~\scoop\apps\dark\3.14.1
Creating shim for 'dark'.
'dark' (3.14.1) was installed successfully!
Installing 'imo-messenger' (1.5.2.3) [64bit] from 'C:\Users\WDAGUtilityAccount\Desktop\ScoopExtras\bucket\imo-messenger.json'
Loading ImoSetup_1.5.2.3_Release.exe from cache
Checking hash of ImoSetup_1.5.2.3_Release.exe ... ok.
Running installer script...done.
Linking ~\scoop\apps\imo-messenger\current => ~\scoop\apps\imo-messenger\1.5.2.3
Creating shortcut for imo Messenger (ImoDesktopApp.exe)
Persisting data
Persisting Logs
'imo-messenger' (1.5.2.3) was installed successfully!

Tested the application

  • application seems to run fine in a minimal test
  • uses persistent data store correctly

Confirmed uninstall

PS C:\Users\WDAGUtilityAccount\Desktop\ScoopExtras> scoop uninstall imo-messenger
Uninstalling 'imo-messenger' (1.5.2.3).
Running pre_uninstall script...done.
Removing shortcut ~\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Scoop Apps\imo Messenger.lnk
Unlinking ~\scoop\apps\imo-messenger\current
'imo-messenger' was uninstalled.

✅Confirmed persistent data is kept in ~\scoop\persist\imo-messenger

Summary by CodeRabbit

  • Updates
    • Application version bumped to 1.5.2.3.
    • Installation workflow replaced with a scripted installer that expands archives and extracts packages for more reliable setup.
    • Uninstall behavior simplified and integrated into the new installer flow for cleaner removals.
    • Download URLs and verification checksum updated for the new release.
    • Version-check logic improved to select the latest release via version-based sorting.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Walkthrough

Bumps imo-messenger manifest to 1.5.2.3; removes depends and pre_uninstall; replaces pre_install with an installer object containing a script array; updates download url, hash, checkver.regex, and autoupdate.url.

Changes

Cohort / File(s) Summary
Package manifest
bucket/imo-messenger.json
Version 1.4.12.4 → 1.5.2.3; removed depends; replaced pre_install with installer.script array (archive expansion + MSI extraction + cleanup); removed pre_uninstall field; updated url and hash; changed checkver.regex to ([\\d.]+) and adjusted autoupdate.url.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify new download URL and hash match the 1.5.2.3 release.
  • Validate installer.script steps correctly extract and place MSI.
  • Confirm checkver.regex reliably captures available versions.

Possibly related PRs

Poem

🐰 I hopped through manifests, tidy and spry,
New scripts in a row and a sharper eye.
Version bumped, old depends gone—hooray!
I nibble the bytes and hop on my way. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: version update to 1.5.2.3, extraction fix, and checkver fix, all directly reflected in the actual code changes.
Description check ✅ Passed The description is comprehensive and complete, including issue reference, detailed testing results, hash verification, VirusTotal confirmation, and all required checklist items marked as completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bb03a6 and 9319dad.

📒 Files selected for processing (1)
  • bucket/imo-messenger.json (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-16T15:59:21.258Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.

Applied to files:

  • bucket/imo-messenger.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (5)
bucket/imo-messenger.json (5)

2-2: LGTM! Version, URL, and hash updates confirmed.

The version bump to 1.5.2.3 with corresponding URL and hash updates aligns with the PR objectives, and testing confirmed successful installation and autoupdate functionality.

Also applies to: 9-10


33-33: Excellent improvement to version detection logic.

Sorting by [version]$_.name instead of pub_time is more reliable for determining the latest version. This ensures that semantic versioning rules are followed (e.g., 1.5.2.3 > 1.5.1.8) regardless of publication order.


36-36: LGTM! Regex simplification matches script output.

The simplified regex ([\\d.]+) correctly captures the version number output by the checkver script (line 34), which writes $latestVersion.name directly without any prefix.


39-39: LGTM! Autoupdate URL is correctly formatted.

The autoupdate URL is a complete valid URI with the $version variable correctly positioned. This matches the pattern of the current URL and complies with Scoop's JSON schema requirements for URI format. Based on learnings, this avoids issues with incomplete URI paths.


11-17: Document installer path fragility risk for future maintenance.

The installer script relies on hardcoded paths (AttachedContainer\ImoInstaller.msi and imo\$version extraction directory) that are vendor-controlled. While current testing confirms these paths work for version 1.5.2.3, vendor changes to the installer structure in future releases could silently break autoupdate without warning. Consider:

  1. Monitoring release notes for installer changes
  2. Adding a comment in the manifest noting this dependency
  3. Setting up periodic validation checks if autoupdate fails

This is a known fragility pattern in Scoop manifests for applications using proprietary installers—maintainability is best ensured through active monitoring rather than proactive path verification.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

imo-messenger

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title [email protected]: new version, wix toolset, checkver fixed imo-messenger: Update to version 1.5.2.3, fix extraction, fix checkver Dec 21, 2025
@z-Fng
Copy link
Member

z-Fng commented Dec 21, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

imo-messenger

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 7f251f7 into ScoopInstaller:master Dec 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants