Skip to content

Conversation

@scillidan
Copy link
Contributor

@scillidan scillidan commented Dec 20, 2025

Relates to #16838

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Added Scoop package manifests enabling installation and automatic updates for AudioBookConverter (v6.6.8) and SSHFS-Win Manager (v1.3.1) via the Scoop package manager.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 20, 2025

Walkthrough

Two new Scoop manifest files are added: one for AudioBookConverter (v6.6.8) and another for SSHFS-Win Manager (v1.3.1). Each manifest defines version metadata, download URLs with SHA-256 hashes, installation shortcuts, and automatic update rules for the Windows package manager.

Changes

Cohort / File(s) Summary
Scoop Manifest Files
bucket/audiobookconverter.json, bucket/sshfs-win-manager.json
Added two Scoop package manifests specifying version, architecture-specific download URLs with SHA-256 checksums, executable shortcuts, GitHub-based version checking, and autoupdate configurations. Enables package installation and updates via Scoop.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify JSON syntax and structure validity
  • Confirm download URLs and SHA-256 hashes are correct and accessible
  • Validate that shortcut and dependency references are appropriately configured

Suggested labels

review-needed

Poem

🐰 Two manifests hop into the bucket bright,
AudioBooks and SSHFS, packaged just right!
With hashes and shortcuts, and versions to match,
Scoop users can grab them—a digital catch!
📦✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'audiobookconverter: Add version 6.6.8' clearly and concisely describes the main change—adding a new manifest file for AudioBookConverter version 6.6.8, which matches the PR's primary objective.
Description check ✅ Passed The PR description includes a reference to the related issue (#16838) and confirms both required checklist items (conventional title format and Contributing Guide acknowledgment), meeting the template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa31461 and 4df7b6b.

📒 Files selected for processing (2)
  • bucket/audiobookconverter.json (1 hunks)
  • bucket/sshfs-win-manager.json (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.
Learnt from: mokosiy
Repo: ScoopInstaller/Extras PR: 16428
File: bucket/multidrive.json:8-8
Timestamp: 2025-10-27T13:19:16.982Z
Learning: For MultiDrive manifests in the ScoopInstaller/Extras repository: the direct download URL at dl.atola.com causes 403 errors due to Cloudflare Bot Fight Mode blocking the Scoop bot, so GitHub Releases URLs should be used instead (e.g., https://github.com/atola-technology/multidrive/releases/download/...).
Learnt from: Lutra-Fs
Repo: ScoopInstaller/Extras PR: 16020
File: bucket/regedix.json:6-8
Timestamp: 2025-09-26T02:55:31.132Z
Learning: For Scoop manifests, prefer using "suggest" over "depends" for .NET runtime dependencies because user machines often have externally managed .NET runtimes already installed, and using "depends" could cause duplicate installations of the same runtime.
Learnt from: SorYoshino
Repo: ScoopInstaller/Extras PR: 16333
File: bucket/potplayer.json:55-64
Timestamp: 2025-10-14T11:15:55.229Z
Learning: In PotPlayer manifests (bucket/potplayer.json), PotPlayer*.ini files (PotPlayer.ini, PotPlayer64.ini, PotPlayerMini.ini, PotPlayerMini64.ini) work correctly with Scoop's hard links and don't need special handling in post_install scripts.
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.

Applied to files:

  • bucket/sshfs-win-manager.json
  • bucket/audiobookconverter.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.

Applied to files:

  • bucket/audiobookconverter.json
🪛 GitHub Actions: Pull Requests
bucket/audiobookconverter.json

[error] 1-1: AudioBookConverter manifest: Hash mismatch detected. Expected hash does not match downloaded asset; autoupdate/checkver also reported failures (Hashes: False, Checkver: False, Autoupdate: False).

🔇 Additional comments (5)
bucket/sshfs-win-manager.json (3)

7-12: No extract_dir needed — archive unpacks directly to app directory.

The release archive contains files at the root level (SSHFS-Win Manager.exe, .dll files, resources/, etc.) with no parent directory wrapper, so the manifest correctly omits extract_dir.


20-26: Upstream does not provide hash files for automated extraction.

The sshfs-win-manager releases do not include SHA-256 checksums or hash files that could be automated in the Scoop manifest's autoupdate block. Hash extraction is not feasible for this package.


6-6: No issues found. The nonportable bucket is a Scoop bucket for non-portable applications, and sshfs-np.json exists in that bucket. The dependency reference nonportable/sshfs-np on line 6 is valid.

bucket/audiobookconverter.json (2)

8-9: Remove or update version reference: release v6.6.8 does not exist.

The latest AudioBookConverter release is version 6.5.2, published on June 21, 2024. The manifest references version 6.6.8, which does not exist as a public GitHub release. Either correct the version to 6.5.2 or defer this manifest until the 6.6.8 release becomes available. The hash cannot be verified for a non-existent release.

Likely an incorrect or invalid review comment.


20-26: Missing hash extraction in autoupdate block — upstream doesn't appear to publish checksums.

AudioBookConverter GitHub releases don't include checksum files or published hashes, making automated hash extraction unavailable. This is similar to other projects that have removed hash verification when upstream checksums aren't provided.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

audiobookconverter

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

sshfs-win-manager

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant