Skip to content

Conversation

@SorYoshino
Copy link
Contributor

@SorYoshino SorYoshino commented Dec 20, 2025

Summary

Improves the goshs manifest by refining metadata consistency and making the checkver and autoupdate logic more robust against upstream changes.

Related commit

Changes

  • Refactor checkver to use the GitHub Releases API with JSONPath and regex-based tag extraction
  • Improve autoupdate URLs to rely on $matchTag instead of assuming a fixed v$version prefix

Testing

The test results are as follows:
┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> .\checkver.ps1 -App goshs -Dir 'D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket' -f
goshs: 1.1.3 (scoop version is 1.1.3)
Forcing autoupdate!
Autoupdating goshs
DEBUG[1766247912] $substitutions (hashtable) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:221:5
DEBUG[1766247912] $substitutions.$underscoreVersion             1_1_3
DEBUG[1766247912] $substitutions.$urlNoExt                      https://github.com/patrickhener/goshs/releases/download/1.1.3/goshs_windows_arm64.tar
DEBUG[1766247912] $substitutions.$matchTag                      1.1.3
DEBUG[1766247912] $substitutions.$url                           https://github.com/patrickhener/goshs/releases/download/1.1.3/goshs_windows_arm64.tar.gz
DEBUG[1766247912] $substitutions.$dashVersion                   1-1-3
DEBUG[1766247912] $substitutions.$minorVersion                  1
DEBUG[1766247912] $substitutions.$dotVersion                    1.1.3
DEBUG[1766247912] $substitutions.$patchVersion                  3
DEBUG[1766247912] $substitutions.$basenameNoExt                 goshs_windows_arm64.tar
DEBUG[1766247912] $substitutions.$preReleaseVersion             1.1.3
DEBUG[1766247912] $substitutions.$buildVersion
DEBUG[1766247912] $substitutions.$majorVersion                  1
DEBUG[1766247912] $substitutions.$cleanVersion                  113
DEBUG[1766247912] $substitutions.$version                       1.1.3
DEBUG[1766247912] $substitutions.$match1                        1.1.3
DEBUG[1766247912] $substitutions.$baseurl                       https://github.com/patrickhener/goshs/releases/download/1.1.3
DEBUG[1766247912] $substitutions.$matchTail
DEBUG[1766247912] $substitutions.$matchHead                     1.1.3
DEBUG[1766247912] $substitutions.$basename                      goshs_windows_arm64.tar.gz
DEBUG[1766247912] $hashfile_url = https://github.com/patrickhener/goshs/releases/download/1.1.3/checksums.txt -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:224:5
Searching hash for goshs_windows_arm64.tar.gz in https://github.com/patrickhener/goshs/releases/download/1.1.3/checksums.txt
DEBUG[1766247913] $filenameRegex = ([a-fA-F0-9]{32,128})[\x20\t]+.*goshs_windows_arm64\.tar\.gz(?:\s|$)|goshs_windows_arm64\.tar\.gz[\x20\t]+.*?([a-fA-F0-9]{32,128}) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:99:13
Found: 025c7e905671ce372d13d0f454bde79fd52020e9271505b697c4fcd7a6fdf0e2 using Extract Mode
Writing updated goshs manifest
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated configuration for version detection and download mechanism to use tag-based identification instead of version-based placeholders.
    • Minor documentation updates to manifest metadata.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 20, 2025

Walkthrough

Updated the goshs.json manifest file to change version detection from v$version format to regex-based $matchTag format, adjusted license URL reference from main to HEAD branch, and added regex field to checkver configuration.

Changes

Cohort / File(s) Summary
Manifest Configuration Updates
bucket/goshs.json
Updated description formatting; changed license URL reference from main/LICENSE to HEAD/LICENSE; converted checkver to include regex field for version tag capture; switched autoupdate download URLs from v$version placeholders to $matchTag format across all architectures (64bit, 32bit, arm64)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Manifest configuration file with straightforward field updates
  • No logic changes or behavioral modifications
  • URL and placeholder substitution pattern is consistent across all architecture blocks

Possibly related PRs

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 A manifest hops to the future bright,
With regex tags now shining in the light,
From v$version old, to $matchTag anew,
Architecture paths dance in matched hue,
The goshs.json sings—update review! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing checkver and autoupdate logic in the goshs manifest at version 1.1.3, which aligns with the detailed changes described in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description is comprehensive and well-structured, covering summary, related commit, detailed changes, and testing results with proof of successful validation.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

goshs

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit cc8479a into ScoopInstaller:master Dec 20, 2025
4 checks passed
@SorYoshino SorYoshino deleted the goshs branch December 20, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants