Skip to content

Conversation

@71zenith
Copy link
Contributor

@71zenith 71zenith commented Dec 20, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Added explicit top-level dependency declarations (includes fzf and an MPV package).
    • Reorganized suggested tooling: removed several individual tool recommendations and replaced them with a "local downloads" option (aria2, yt-dlp) and an "alternate player" option (VLC).
    • No other metadata or update behavior changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 20, 2025

Walkthrough

Added a top-level dependency array and reorganized the manifest's suggestion entries in bucket/ani-cli.json, replacing several direct tool suggestions with categorized entries for local downloads and an alternate player.

Changes

Cohort / File(s) Summary
Dependency & suggestion reorganization
bucket/ani-cli.json
Added top-level depends array including fzf and extras/mpv. Simplified suggest by removing direct tool entries (git, fzf, wget, aria2, mpv, ffmpeg and ffmpeg-shared) and introducing local downloads array (aria2, yt-dlp) and alternate player (extras/vlc). Other manifest fields unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single JSON manifest with small, well-scoped structural edits.
  • Review attention: validate dependency names/paths, ensure suggest schema remains compatible with consumers, confirm no typos in new entries.

Poem

🐰 I nudged the manifest, tidy and bright,
Dependencies stacked, suggestions put right,
Downloads in a basket, a player aside,
A hop, a tweak — the CLI's satisfied! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description follows the repository template with proper checkboxes marked, confirming adherence to conventional PR title format and the Contributing Guide.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main changes: moving hard dependencies to the depends field and simplifying the suggest structure for ani-cli.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

Invalid manifests

  • ani-cli

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc8479a and e45bac1.

📒 Files selected for processing (1)
  • bucket/ani-cli.json (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/ani-cli.json

[error] 1-1: Invalid JSON in ani-cli.json. PR contains invalid manifests (ani-cli).

🔇 Additional comments (1)
bucket/ani-cli.json (1)

6-9: Fix JSON syntax error: remove trailing comma on line 15.

The file contains invalid JSON due to a trailing comma after "extras/vlc" on line 15. This prevents the manifest from being parsed and must be fixed before any changes can be approved.

Additionally, consider using "suggest" instead of "depends" for fzf and extras/mpv, as these tools are often already present on user machines. Using "depends" can cause unnecessary duplicate installations when users have externally managed versions of these tools.

⛔ Skipped due to learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16328
File: bucket/winutil.json:0-0
Timestamp: 2025-10-13T09:37:06.093Z
Learning: When reviewing code in Scoop manifests, always verify the actual file content if the diff appears incomplete or unusual, as diff context can be truncated or displayed incorrectly. The pattern `[string[]](...).ForEach{...}` is commonly used in post_uninstall scripts across the Extras repository.

@z-Fng z-Fng changed the title ani-cli: move hard dependencies to depends ani-cli@4.10: Move hard dependencies to depends, simplify suggest Dec 27, 2025
@z-Fng
Copy link
Member

z-Fng commented Dec 27, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

ani-cli

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 828d38a into ScoopInstaller:master Dec 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants