-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ani-cli@4.10: Move hard dependencies to depends, simplify suggest #16842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded a top-level dependency array and reorganized the manifest's suggestion entries in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with Invalid manifests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/ani-cli.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/ani-cli.json
[error] 1-1: Invalid JSON in ani-cli.json. PR contains invalid manifests (ani-cli).
🔇 Additional comments (1)
bucket/ani-cli.json (1)
6-9: Fix JSON syntax error: remove trailing comma on line 15.The file contains invalid JSON due to a trailing comma after
"extras/vlc"on line 15. This prevents the manifest from being parsed and must be fixed before any changes can be approved.Additionally, consider using
"suggest"instead of"depends"for fzf and extras/mpv, as these tools are often already present on user machines. Using"depends"can cause unnecessary duplicate installations when users have externally managed versions of these tools.⛔ Skipped due to learnings
Learnt from: o-l-a-v Repo: ScoopInstaller/Extras PR: 16328 File: bucket/winutil.json:0-0 Timestamp: 2025-10-13T09:37:06.093Z Learning: When reviewing code in Scoop manifests, always verify the actual file content if the diff appears incomplete or unusual, as diff context can be truncated or displayed incorrectly. The pattern `[string[]](...).ForEach{...}` is commonly used in post_uninstall scripts across the Extras repository.
|
/verify |
|
All changes look good. Wait for review from human collaborators. ani-cli
|
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.